Open
Conversation
pablisch
reviewed
Apr 15, 2023
| require_relative './lib/dm_repository' | ||
| require 'sinatra/flash' | ||
| require_relative './lib/database_connection' | ||
| require "sinatra/base" |
Contributor
There was a problem hiding this comment.
I always prefer a " over a ' 😀
pablisch
reviewed
Apr 15, 2023
| expect(response.status).to eq 200 | ||
| expect(response.body).to include "You are logged in" | ||
|
|
||
| response = post("/send_message", recipient_handle: "Sam", contents: "Hello") |
Contributor
There was a problem hiding this comment.
this test covers so much more than its purpose. I am wondering if it could be restricted to just the send_message route so that the test is not affected by all the other things outside its parameters. This route should only be available when logged in so I am wondering, if it can't be tested independently, we should be looking at why not?
pablisch
approved these changes
Apr 15, 2023
Contributor
pablisch
left a comment
pablisch
left a comment
There was a problem hiding this comment.
Awesome work! Now get some rest 💛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed send_message post and get routes. I think I've doubled up on a 'find id by handle method' looking at main. I put one in user repo and it looks like there's one in the helper methods in app.rb already - so that needs to be resolved in the merge. Will also need to add a link on the homepage view to get to send_message view.